Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fedora CI following ipset version in kube-proxy for k8s 1.23 #8397

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

floryut
Copy link
Member

@floryut floryut commented Jan 10, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
Incompatible ipset protocol version (7) included in kube-proxy since k8s 1.23, is causing issue with fedora kernel.
projectcalico/calico#5011
Bad return code from 'ipset list'. error=exit status 1 family="inet" stderr="ipset v7.1: Kernel and userspace incompatible: settype hash:ip,port with revision 6 not supported by userspace.

Which issue(s) this PR fixes:
Fixes
https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1956025018
https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1957228282

Special notes for your reviewer:
Switching to iptables instead of ipvs in the meantime..
=> https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1959178378
=> https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1959178373

Does this PR introduce a user-facing change?:

[⚠️ ADD NOTE: For now Calico and K8S 1.23 might broke under some OS, careful !]

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@floryut floryut marked this pull request as draft January 10, 2022 12:03
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2022
@floryut floryut force-pushed the fix_fedora branch 3 times, most recently from ba4fafe to ab84c01 Compare January 10, 2022 14:12
@floryut floryut changed the title Fix kube_resolv_conf for strict validation of revolvConf in kubelet-config Debug Fedora nightly Jan 10, 2022
@floryut floryut force-pushed the fix_fedora branch 2 times, most recently from e843a83 to 5087b6a Compare January 10, 2022 17:10
@floryut floryut changed the title Debug Fedora nightly Fix Fedora CI due to kube-proxy mode Jan 10, 2022
@floryut floryut changed the title Fix Fedora CI due to kube-proxy mode Fix Fedora CI following ipset version in k8s 1.23 Jan 10, 2022
@floryut floryut changed the title Fix Fedora CI following ipset version in k8s 1.23 Fix Fedora CI following ipset version in kube-proxy for k8s 1.23 Jan 10, 2022
@floryut floryut force-pushed the fix_fedora branch 2 times, most recently from 8f8a788 to fdf5f79 Compare January 10, 2022 17:39
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2022
@floryut floryut marked this pull request as ready for review January 10, 2022 17:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2022
@floryut
Copy link
Member Author

floryut commented Jan 10, 2022

/hold need to rename commit, tomorrow

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2022
@floryut
Copy link
Member Author

floryut commented Jan 11, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2022
@cristicalin
Copy link
Contributor

Let's hope this gets fixed in time for 2.19 and we don't have to apply this workaround for too long.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit d007132 into kubernetes-sigs:master Jan 11, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants